*: add basic health check service #8121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
suggested changes
Jun 19, 2017
clientv3/client.go
Outdated
| @@ -463,6 +466,15 @@ func (c *Client) checkVersion() (err error) { | |||
| // ActiveConnection returns the current in-use connection | |||
| func (c *Client) ActiveConnection() *grpc.ClientConn { return c.conn } | |||
|
|
|||
| // CheckHealth checks the health status of gRPC server of current connection. | |||
There was a problem hiding this comment.
don't expose through clientv3 yet? User can get this by healthpb.NewHeathClient(c.ActiveConnection()) already
clientv3/integration/kv_test.go
Outdated
| ) | ||
|
|
||
| func TestHealth(t *testing.T) { |
There was a problem hiding this comment.
this should be in integration/ instead of clientv3/integration/ since it's mostly only testing the server
integration/cluster.go
Outdated
| @@ -937,6 +937,10 @@ func (c *ClusterV3) Client(i int) *clientv3.Client { | |||
| return c.clients[i] | |||
| } | |||
|
|
|||
| func (c *ClusterV3) TerminateMember(t *testing.T, i int) { | |||
There was a problem hiding this comment.
Members is already exported out of ClusterV3; function is unnecessary?
gyuho
changed the title
gyuho
force-pushed
the
health-check-service
branch
from
8f11d5f
to
df46e1d
Compare
gyuho
force-pushed
the
health-check-service
branch
2 times, most recently
from
d0bfd87
to
031d3ce
Compare
|
@heyitsanthony PTAL. |
integration/v3_health_check_test.go
Outdated
| @@ -0,0 +1,40 @@ | |||
| // Copyright 2017 The etcd Authors | |||
There was a problem hiding this comment.
just v3_health_test.go?
heyitsanthony
approved these changes
Jun 20, 2017
Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
force-pushed
the
health-check-service
branch
from
031d3ce
to
8ce2c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #8022.
This PR uses the default grpc health server https://github.com/grpc/grpc-go/blob/master/health/health.go. Any other suggestion?
Balancer logic is not implemented in this PR.